Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIGH] Bump directlinejs in core #3419

Merged
merged 1 commit into from
Aug 17, 2020
Merged

[HIGH] Bump directlinejs in core #3419

merged 1 commit into from
Aug 17, 2020

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Aug 17, 2020 •
edited by compulim
Loading

Changelog Entry

(Filled previously)

Description

Bump [[email protected]] in botframework-webchat-core.

Design

Specific Changes

  • I have added tests and executed them locally
    • Will validate in PR validation
  • I have updated CHANGELOG.md
    • Filled previously
  • I have updated documentation
    • N/A

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Tests reviewed (coverage, legitimacy)

@corinagum corinagum changed the title Bump directlinejs in core [HIGH] Bump directlinejs in core Aug 17, 2020
@corinagum corinagum merged commit 4a9b0a4 into microsoft:master Aug 17, 2020
@compulim compulim mentioned this pull request Aug 18, 2020
Closed
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corinagum @compulim